From: "flichtenheld (Code Review)"
Date: Fri, 12 Jan 2024 16:25:11 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515...,
openvpn-devel@lists.sourceforge.net, gert@...1296..., lstipakov@...277...
Message-ID: <488f9fd008f8e8eb960628fb7308c6ed976889a3-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="6rnkFMUHsQ4="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce
'block-local' with WFP filters
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: d12fk
Cc: stipa , cron2 , plaisthos , openvpn-devel
--6rnkFMUHsQ4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, d12fk, plaisthos, stipa.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/489?usp=3Demail )
Change subject: Windows: enforce 'block-local' with WFP filters
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS5:
Generally looks fine to me
File src/openvpn/win32.c:
http://gerrit.openvpn.net/c/openvpn/+/489/comment/4f22baef_1cbaf8d1 :
PS1, Line 1225: if (ret =3D=3D false)
> Yes, but no. The function has a single point of return, let's keep it tha=
t way. [=E2=80=A6]
Acknowledged
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 5
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: cron2
Gerrit-CC: openvpn-devel
Gerrit-CC: stipa
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: d12fk
Gerrit-Attention: stipa
Gerrit-Comment-Date: Fri, 12 Jan 2024 16:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld
Comment-In-Reply-To: d12fk
Gerrit-MessageType: comment
--6rnkFMUHsQ4=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, d12fk, plaisthos, stipa. <=
/p>
Patch set 5:Code-Review +1=
Vi=
ew Change
2 comments:
Acknowledged
<=
/ul>To view, visit change 489. To unsubscribe, or for help writing mail filte=
rs, visit settings.
<=
div itemscope itemtype=3D"http://schema.org/EmailMessage">
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f=
071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 5
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <=
/div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: d12fk <heiko@...515...>=
;
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Fri, 12 Jan 2024 16:25:11=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Comment-In-Reply-To: d12fk <heiko@...515...=
>
Gerrit-MessageType: comment
--6rnkFMUHsQ4=--