From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Re: Allow compile with CONFIG_DEBUG_INFO=y,	X86_PAE
	not set on gcc 3.4.5
Date: Fri, 08 Aug 2008 08:21:41 -0700
Message-ID: <489C6485.7050009@goop.org>
References: <20080808050429.GA8473@verge.net.au> <489BE9C3.2010006@goop.org>
	<20080808080155.GA1992@cs181140183.pp.htv.fi>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080808080155.GA1992@cs181140183.pp.htv.fi>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Adrian Bunk <bunk@kernel.org>
Cc: Mark McLoughlin <markmc@redhat.com>, xen-devel@lists.xensource.com, Eduardo Habkost <ehabkost@redhat.com>, Stephen Tweedie <sct@redhat.com>, linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>, "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, Dhaval Giani <dhaval@linux.vnet.ibm.com>
List-Id: xen-devel@lists.xenproject.org

Adrian Bunk wrote:
> CONFIG_DEBUG_INFO=y is why I never hit it before.
>
> It does not seem to be just one dodgy Redhat compiler (as I assumed in 
> the Bugzilla entry) but the whole 3.4 series of gcc which makes our 
> resolution of saying that this specific compiler is broken invalid.
>
> Considering that we officially support all compilers >= 3.2 this is just 
> one more case where we have to add to the kernel a workaround for a 
> broken compiler.
>   

Yes.  I'm happy to write off a specific rpm package, but a whole series 
is a different matter.

Adding

	if (PREALLOCATED_PMDS == 0)
		return;

in the appropriate places with a small comment seems like the right answer.

    J