From: Jeremy Fitzhardinge Subject: Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table Date: Sun, 07 Sep 2008 17:03:23 -0700 Message-ID: <48C46BCB.2060209@goop.org> References: <944fe7ea3da7707eb90f.1220826078@localhost> <20080907234418.GB26079@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080907234418.GB26079@one.firstfloor.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andi Kleen Cc: Ingo Molnar , Xen Devel , linux-kernel@vger.kernel.org, "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org Andi Kleen wrote: > On Sun, Sep 07, 2008 at 03:21:18PM -0700, Jeremy Fitzhardinge wrote: > >> __acpi_map_table() effectively reimplements early_ioremap(). Rather >> than have that duplication, just implement it in terms of >> early_ioremap(). >> >> However, unlike early_ioremap(), __acpi_map_table() just maintains a >> single mapping which gets replaced each call, and has no corresponding >> unmap function. Implement this by just removing the previous mapping >> each time its called. Unfortunately, this will leave a stray mapping >> at the end. >> > > It would be better to just fix the ACPI code to unmap. I was concerned that would cause lots of cross-arch churn, but of course the only other relevant architecture is ia64. I'll prep a followup patch. J