From: "Jan Beulich" Subject: Re: [PATCH] fix misc issues related to allowingsupport of more CPUs Date: Mon, 22 Sep 2008 08:46:33 +0100 Message-ID: <48D76979.76E4.0078.0@novell.com> References: <48D3BEE7.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 20.09.08 10:36 >>> >On 19/9/08 14:01, "Jan Beulich" wrote: > >> Includes a small improvement (I think) to last_cpu(), and a necessary >> conversion from BUG_ON() to WARN_ON() in vsnprintf(). > >Why must it be WARN_ON()? You think you could specify strings so long = that >they overflow 32 bits? You've got other problems in that case. No, that's not the reason. It's because of how bitmap_scnprintf() and bitmap_scnlistprintf() work - they can (validly, assuming that the code having been derived from Linux and still being that way in Linux, hence apparently considered correct) pass negative sizes to scnprintf(), and hence it must not kill the system to actually do so. Jan