Return-Path: Received: from imap.sh.mvista.com (unknown [63.81.120.155]) by ozlabs.org (Postfix) with ESMTP id 7B547DDEE3 for ; Wed, 24 Sep 2008 20:24:16 +1000 (EST) Message-ID: <48DA1544.5010307@ru.mvista.com> Date: Wed, 24 Sep 2008 14:24:04 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: avorontsov@ru.mvista.com Subject: Re: [PATCH 3/3] USB: driver for Freescale QUICC Engine USB Host Controller References: <20080918151659.GA20140@oksana.dev.rtsoft.ru> <20080918151746.GC31187@oksana.dev.rtsoft.ru> <20080919162324.e354ed2f.akpm@linux-foundation.org> <20080923183129.GA19024@oksana.dev.rtsoft.ru> <48D96052.6090005@ru.mvista.com> <48D9612D.7060601@ru.mvista.com> <20080923225730.GB13617@oksana.dev.rtsoft.ru> In-Reply-To: <20080923225730.GB13617@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=windows-1251; format=flowed Cc: dbrownell@users.sourceforge.net, greg@kroah.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Andrew Morton , leoli@freescale.com, timur@freescale.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. Anton Vorontsov wrote: >>>>>> This controller does not integrate the root hub, so this driver also >>>>>> fakes one-port hub. External hub is required to support more than >>>>>> one device. >>>>>> >>>>>> ... >>>>>> >>>>>> >>>>>> >>>>> Please, no. >>>>> >>>>> >>>> What exactly 'no'? ;-) >>>> >>>> >>> No one-port hubs I guess -- they are pointless. Though e.g. MUSB >>> driver creates one -- I guess to impersonate a transaction translating >>> high-speed hub... >>> >>> >> ... then the root hub emulation is completely pointless. >> > > It isn't. We always should emulate the root hub. The root hub > is part and parcel of any USB Host. Even the one-port one. Hm, maybe that's what USB core thinks (because UHCI/OHCI/EHCI all have it) but e.g. MUSB doesn't have the root hub registers... I looked at the core and figured that USB core seems to use the root hub interface for port PM, etc. and expects it to bee present, so it seems unavoidable indeed... :-/ WBR, Sergei