From: "Zhao, Yu" Subject: Re: [PATCH 12/15 v5] PCI: support the SR-IOV capability Date: Wed, 22 Oct 2008 11:05:26 +0800 Message-ID: <48FE9876.9040003@intel.com> References: <20081021114056.GA3185@yzhao12-linux.sh.intel.com> <20081021115308.GM3185@yzhao12-linux.sh.intel.com> <20081021165054.GA24795@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "linux-pci@vger.kernel.org" , "jbarnes@virtuousgeek.org" , "randy.dunlap@oracle.com" , "grundler@parisc-linux.org" , "achiang@hp.com" , "matthew@wil.cx" , "rdreier@cisco.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" To: Greg KH Return-path: In-Reply-To: <20081021165054.GA24795@kroah.com> Sender: linux-pci-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Greg KH wrote: > On Tue, Oct 21, 2008 at 07:53:08PM +0800, Yu Zhao wrote: >> Support Single Root I/O Virtualization (SR-IOV) capability. >> >> Cc: Jesse Barnes >> Cc: Randy Dunlap >> Cc: Grant Grundler >> Cc: Alex Chiang >> Cc: Matthew Wilcox >> Cc: Roland Dreier >> Cc: Greg KH >> Signed-off-by: Yu Zhao >> >> +#define iov_config_attr(field) \ >> +static ssize_t field##_show(struct device *dev, \ >> + struct device_attribute *attr, char *buf) \ >> +{ \ >> + struct pci_dev *pdev = to_pci_dev(dev); \ >> + return sprintf(buf, "%d\n", pdev->iov->field); \ >> +} >> + >> +iov_config_attr(status); >> +iov_config_attr(totalvfs); >> +iov_config_attr(initialvfs); >> +iov_config_attr(numvfs); > > As you are adding new sysfs entries, can you also create the proper > documentation in Documentation/ABI/ so that people can understand how to > use them? Yes, I see you added a stand-alone document, but putting it > in the "standard" format is also necessary. Thanks for reminding me about this. I used to update ABI doc in earlier versions, but somehow forgot to do this after several carry-forwards... Will complete it in next version. Regards, Yu