From: "cron2 (Code Review)" Date: Sat, 24 Jan 2026 18:21:35 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <48aa363ffa2c78cfa3698ecf3d382115a86f87d2-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="RGdtVD2ELXA="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: status: Avoid conversion warnings in status_read/status_printf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --RGdtVD2ELXA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.o= penvpn.net/c/openvpn/+/1485?usp=3Demail ) Change subject: status: Avoid conversion warnings in status_read/status_pri= ntf ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/openvpn/status.c: http://gerrit.openvpn.net/c/openvpn/+/1485/comment/d724e493_5742107d?usp=3D= email : PS2, Line 241: if (write(so->fd, buf, (unsigned int)len) != =3D len) this change confuses me. In my manpage, `write()` wants a `size_t count` (= linux) or `size_t nbytes` (FreeBSD), and so `size_t len` should be perfectl= y fine. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1485?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a00248e4dc3e8c9 Gerrit-Change-Number: 1485 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sat, 24 Jan 2026 18:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --RGdtVD2ELXA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: flichtenheld, plaisthos.

Patch set 2:Code-Review -1=

V= iew Change

1 comment:

  • File src/openvpn/status.c:

    <= ul style=3D"list-style: none; padding: 0;">
  • Patch Set = #2, Line 241: = if (write(so->fd, buf, (unsigned int)len) !=3D len)

    th= is change confuses me. In my manpage, `write()` wants a `size_t count` (li= nux) or `size_t nbytes` (FreeBSD), and so `size_t len` should be perfectly = fine.

To view, visit change 1485. To unsubscribe, or = for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iff1343a2f8cc7e32b8f36b359a0= 0248e4dc3e8c9
Gerrit-Change-Number: 1485
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sat, 24 Jan 2026 18:21:35= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --RGdtVD2ELXA=--