From: Jerry Van Baren Date: Wed, 12 Nov 2008 13:16:48 -0500 Subject: [U-Boot] [PATCH] Makefile: use find to simplify clobber and avoid some bash problem In-Reply-To: <1226513192-14724-1-git-send-email-plagnioj@jcrosoft.com> References: <1226511288.18428.1020.camel@localhost.localdomain> <1226513192-14724-1-git-send-email-plagnioj@jcrosoft.com> Message-ID: <491B1D90.2090602@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > please try this on ubuntu > > Best Regards, > J. > Makefile | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 884b634..212451f 100644 > --- a/Makefile > +++ b/Makefile > @@ -3280,9 +3280,8 @@ clobber: clean > @rm -f $(OBJS) $(obj)*.bak $(obj)ctags $(obj)etags $(obj)TAGS \ > $(obj)cscope.* $(obj)*.*~ > @rm -f $(obj)u-boot $(obj)u-boot.map $(obj)u-boot.hex $(ALL) > - @rm -f $(obj)tools/{crc32.c,env_embedded.c,env/crc32.c,md5.c,sha1.c,inca-swap-bytes} > - @rm -f $(obj)tools/{image.c,fdt.c,fdt_ro.c,fdt_rw.c,fdt_strerror.c,zlib.h} > - @rm -f $(obj)tools/{fdt_wip.c,libfdt_internal.h} > + @find $(obj)tools -name "*" -type l -print | xargs rm -f > + @rm -f $(obj)tools/inca-swap-bytes > @rm -f $(obj)cpu/mpc824x/bedbug_603e.c > @rm -f $(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm > @[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l -print | xargs rm -f Oooo, you have a risk of removing symlinks that you didn't mean to. Works today, what about tomorrow? This was discussed previously, but not pushed to fruition: My vote is (a) use bash specifically and keep the bashisms. Best regards, gvb