From: Jeremy Fitzhardinge Subject: Re: [PATCH 30 of 38] xen: implement io_apic_ops Date: Thu, 20 Nov 2008 09:07:45 -0800 Message-ID: <49259961.1030309@goop.org> References: <20081120083329.GA13996@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081120083329.GA13996@verge.net.au> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Simon Horman Cc: the arch/x86 maintainers , Ingo Molnar , Xen-devel , linux-kernel@vger.kernel.org, Ian Campbell List-Id: xen-devel@lists.xenproject.org Simon Horman wrote: > Hi, > > it seems that if CONFIG_XEN is set by CONFIG_XEN_DOM0 is not set, > then the call to xen_init_apic() in xen_start_kernel() causes the > build to fail. > > One possible soluion to this is to provide a dummy > version of xen_init_apic() in the !CONFIG_XEN_DOM0 case. > > Another possible solution would be to add #ifdef CONFIG_XEN_DOM0 > inside xen_start_kernel() > Ah, OK, will fix that up. J