From: Michael Tokarev Subject: virtio_pci module refcount? Date: Wed, 03 Dec 2008 15:51:33 +0300 Message-ID: <493680D5.6090502@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: KVM list Return-path: Received: from hobbit.corpit.ru ([81.13.33.150]:24798 "EHLO hobbit.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbYLCMvf (ORCPT ); Wed, 3 Dec 2008 07:51:35 -0500 Sender: kvm-owner@vger.kernel.org List-ID: Hello. Yesterday I experimented with kvm guests (the "hangs" issue), and by a chance rmmod'ed the "wrong" module - it was virtio_pci. Which resulted in an immediate OOPs and hang, like this: WARNING: at drivers/base/core.c:122 device_release+0x5f/0x70() Device 'virtio1' does not have a release() function, it is broken and must be fixed. Modules linked in: ext3 jbd mbcache acpiphp dock pci_hotplug virtio_net virtio_blk virtio_pci(-) virtio_ring virtio Pid: 361, comm: rmmod Tainted: G S 2.6.27-i686smp #2.6.27.7 [] warn_slowpath+0x6f/0xa0 [] prepare_set+0x30/0x80 [] __wake_up+0x3e/0x60 [] release_sysfs_dirent+0x45/0xb0 ... It looks like virtio_pci module should either use proper refcounting as other modules, or really should be unloadable... Thanks! /mjt