From: Phillip Lougher Subject: Re: [PATCH] Update the exportfs documentation and comments and fix some exportfs issues Date: Thu, 04 Dec 2008 04:50:16 +0000 Message-ID: <49376188.3010303@lougher.demon.co.uk> References: <49364304.7000501@lougher.demon.co.uk> <20081202210233.19035.48005.stgit@warthog.procyon.org.uk> <29007.1228301690@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: hch@infradead.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: David Howells Return-path: Received: from anchor-post-3.mail.demon.net ([195.173.77.134]:57892 "EHLO anchor-post-3.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbYLDEuK (ORCPT ); Wed, 3 Dec 2008 23:50:10 -0500 In-Reply-To: <29007.1228301690@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: David Howells wrote: > Phillip Lougher wrote: > >> You define these in the filesystem c files themselves as #defines. UDF and >> BTRFS place theirs in the enum fid_type definition itself (in >> linux/exportfs.h). Is there any reason why you didn't do this? > > I don't know that we want to stick loads of filesystem-specific stuff into a > general header file. I believe we used to do that for struct inode (IIRC > there used to be a large union with filesystem-specific members). FYI yes we did, back in the 2.4.x days, not only for struct inode but also for struct super-block. Personally I don't care where things are put, just as long as there's consensus. > I know. As far as I know, there's no restriction on them reusing types 1 and > 2, just an advisory note where these collide with other export types. Perhaps > Al or Christoph would care to comment on this. > > Also, I don't know that changing these types would necessarily be a good > idea. wireshark, for example, could multiplex the types by the length as the > standard types are lengths 2 and 4, and ISOFS types are 3 and 5. > Quite, except ocfs2 also uses type 1 with a length of 3 :-) (it uses type 2 with a length of 6). People on LKML often complain too few people review patches. I get the feeling I wish I never bothered here. Phillip