From: pat-lkml <pat-lkml@erley.org>
Date: Fri, 05 Dec 2008 22:07:47 -0500
Subject: [ath9k-devel] [PATCH] ath9k: Free Beacon skbs in AP mode
In-Reply-To: <20081205184245.GA10596@jm.kir.nu>
References: <20081205184245.GA10596@jm.kir.nu>
Message-ID: <4939EC83.4060908@erley.org>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

Jouni Malinen wrote:
> Fix a memory leak where AP mode did not free transmitted Beacon frame
> skbs.
> 
> Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
> 
> Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c	2008-12-05 18:37:37.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/ath9k/beacon.c	2008-12-05 18:38:41.000000000 +0200
> @@ -167,6 +167,7 @@
>  		pci_unmap_single(sc->pdev, bf->bf_dmacontext,
>  				 skb->len,
>  				 PCI_DMA_TODEVICE);
> +		dev_kfree_skb_any(skb);
>  	}
>  
>  	skb = ieee80211_beacon_get(sc->hw, vif);
> 

Acked-by: Pat Erley <pat-lkml@erley.org>

I've been using ath9k in master mode for a few weeks and
had noticed a severe memory leak (kill a gig of ram system in about a
day).  Figured it was just in hostapd, and haven't had time to track it
down.