From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 04 of 14] swiotlb: consistently use address_needs_mapping
 everywhere
Date: Wed, 17 Dec 2008 08:40:08 -0800
Message-ID: <49492B68.7040509@goop.org>
References: <patchbomb.1229458644@abulafia.goop.org>	<aba0c734944520d4b892.1229458648@abulafia.goop.org> <20081217113804F.fujita.tomonori@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1752295AbYLQQk3@vger.kernel.org>
In-Reply-To: <20081217113804F.fujita.tomonori@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, x86@kernel.org, ian.campbell@citrix.com, jbeulich@novell.com
List-Id: xen-devel@lists.xenproject.org

FUJITA Tomonori wrote:
> On Tue, 16 Dec 2008 12:17:28 -0800
> Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>> ---
>>  lib/swiotlb.c |   10 +++-------
>>  1 file changed, 3 insertions(+), 7 deletions(-)
>>     
>
> This patch is wrong.
>
> dma_mask and coherent_dma_mask represent different restrictions.
>
> You can't use coherent_dma_mask for alloc_coherent.
>   

OK.  It looks like this patch is just an (erroneous) cleanup, so we can 
drop it.

    J