From: Jeremy Fitzhardinge Subject: Re: [PATCH UPDATED] xen/xenfs: fix xenbus message reads Date: Wed, 17 Dec 2008 13:40:06 -0800 Message-ID: <494971B6.6040508@goop.org> References: <49480F39.2010102@goop.org> <20081216125425.30524946.akpm@linux-foundation.org> <49496E17.2010703@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49496E17.2010703@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andrew Morton Cc: alex.zeffertt@eu.citrix.com, Ian.Campbell@citrix.com, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, viro@ftp.linux.org.uk, mingo@elte.hu List-Id: xen-devel@lists.xenproject.org Compute the remaining data size properly. Signed-off-by: Jeremy Fitzhardinge --- drivers/xen/xenfs/xenbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) =================================================================== --- a/drivers/xen/xenfs/xenbus.c +++ b/drivers/xen/xenfs/xenbus.c @@ -132,7 +132,7 @@ rb = list_entry(u->read_buffers.next, struct read_buffer, list); i = 0; while (i < len) { - unsigned sz = min((unsigned)len - i, rb->cons - rb->len); + unsigned sz = min((unsigned)len - i, rb->len - rb->cons); ret = copy_to_user(ubuf + i, &rb->msg[rb->cons], sz);