From: Jeremy Fitzhardinge Subject: Re: [PATCH UPDATED] xen: add xenfs to allow usermode <-> Xen interaction Date: Wed, 17 Dec 2008 13:50:52 -0800 Message-ID: <4949743C.2040306@goop.org> References: <49480F39.2010102@goop.org> <20081216125425.30524946.akpm@linux-foundation.org> <49496E17.2010703@goop.org> <20081217133429.b64e6421.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20081217133429.b64e6421.akpm@linux-foundation.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andrew Morton Cc: alex.zeffertt@eu.citrix.com, Ian.Campbell@citrix.com, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, viro@ftp.linux.org.uk, mingo@elte.hu List-Id: xen-devel@lists.xenproject.org Andrew Morton wrote: > I'm bored of your filesystem, so I think I'll just merge it, unless > someone else wants to ;) > Yay! Boring code Wins! > Was this noticed and considered? > > WARNING: consider using strict_strtoul in preference to simple_strtoul > #543: FILE: drivers/xen/xenfs/xenbus.c:315: > + trans->handle.id = simple_strtoul(reply, NULL, 0); > Noticed that, but wasn't sure how to handle an error there anyway. Something pretty horrible must have happened at the other end. J