From: Ankit Jain Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Date: Thu, 18 Dec 2008 15:24:43 +0530 Message-ID: <494A1DE3.5090203@ankitjain.org> References: <49460F88.2080408@ankitjain.org> <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Al Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, mfasheh@suse.com, joel.becker@oracle.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com To: Felix Blyakher Return-path: Received: from qb-out-0506.google.com ([72.14.204.229]:55868 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbYLRJzS (ORCPT ); Thu, 18 Dec 2008 04:55:18 -0500 Received: by qb-out-0506.google.com with SMTP id f11so172905qba.17 for ; Thu, 18 Dec 2008 01:55:17 -0800 (PST) In-Reply-To: <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Felix Blyakher wrote: > >> This patch adds ioctls to vfs for compatibility with legacy XFS >> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation >> effectively invokes sys_fallocate for the new ioctls. > > I don't think we can use sys_fallocate for XFS_IOC_UNRESVSP* > commands, which suppose to release currently allocated file > blocks. > See more comments below. My bad :( I'll drop the *UNRESV* completely from the new ioctl and post an updated patch. -Ankit