From: "selvanair (Code Review)" Date: Tue, 31 Mar 2026 18:57:31 +0000 In-Reply-To: References: Reply-To: selva.nair@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <495021c7815f35af11bd58bfb8fd2ee97e672f67-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="vcoruvarQpU="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Log when writing username/password to TLS buffer fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --vcoruvarQpU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. selvanair has posted comments on this change by selvanair. ( http://gerrit.= openvpn.net/c/openvpn/+/1600?usp=3Demail ) Change subject: Log when writing username/password to TLS buffer fails ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think this should be a M_FATAL but, for some reason, the current behaviou= r is to continue. That leads to repeated retries that never succeeds. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1600?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9468811fd434e17645957fc12770aa2b9ed98fb8 Gerrit-Change-Number: 1600 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Tue, 31 Mar 2026 18:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --vcoruvarQpU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #1:

      I think this sh= ould be a M_FATAL but, for some reason, the current behaviour is to continu= e. That leads to repeated retries that never succeeds.

  • To view, visit change 1600. To unsubscribe, or for help writing mail filt= ers, visit setti= ngs.

    Gerrit-MessageType: comment
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I9468811fd434e17645957fc1277= 0aa2b9ed98fb8
    Gerrit-Change-Number: 1600
    Gerrit-PatchSet: 1
    Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Tue, 31 Mar 2026 18:57:31= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    = --vcoruvarQpU=--