From: Gabor Juhos Date: Mon, 05 Jan 2009 13:23:45 +0100 Subject: [ath9k-devel] [RFC 08/12] ath9k: get EEPROM contents from platform data on AHB bus In-Reply-To: <18785.57618.47120.669270@gargle.gargle.HOWL> References: <1230990262-22923-1-git-send-email-juhosg@openwrt.org> <1230990262-22923-9-git-send-email-juhosg@openwrt.org> <18785.57618.47120.669270@gargle.gargle.HOWL> Message-ID: <4961FBD1.4030103@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Sujith ?rta: > Gabor Juhos wrote: >> +#ifndef _LINUX_ATH9K_PLATFORM_H >> +#define _LINUX_ATH9L_PLATFORM_H > > Typo ? Oops, yes. > Also, after addressing Christopher's comments, I don't think too many > bus specific routines would remain. In that case would it be reasonable > to just have a single file (bus.c, with appropriate ifdefs), instead > of pci.c and ahb.c ? We will have 3 of them actually (read_cachesize, read_eeprom, cleanup), but here is the whole {pci,platform}_driver specific stuff. Of course we can move all of this into one file, but i would like to avoid the unnecessary ifdefs where it is possible. Apart from this, if we will put the PCI and AHB stuff into one file, we could put it into main.c simply. -Gabor