From: Gabor Juhos Date: Fri, 09 Jan 2009 21:40:12 +0100 Subject: [ath9k-devel] [PATCH v2 08/11] ath9k: remove (u16) casts from rtc register access In-Reply-To: <1231519108.24032.1.camel@dv> References: <1231503868-29226-1-git-send-email-juhosg@openwrt.org> <1231503868-29226-9-git-send-email-juhosg@openwrt.org> <1231519108.24032.1.camel@dv> Message-ID: <4967B62C.1050203@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Pavel Roskin ?rta: > On Fri, 2009-01-09 at 13:24 +0100, Gabor Juhos wrote: >> The RTC register offsets don't fit into 'u16' on the AR913x, so we have >> to remove the existing casts. >> >> Signed-off-by: Gabor Juhos >> Signed-off-by: Imre Kaloz >> --- >> drivers/net/wireless/ath9k/hw.c | 14 +++++++------- >> 1 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/net/wireless/ath9k/hw.c b/drivers/net/wireless/ath9k/hw.c >> index 088d968..742ecc1 100644 >> --- a/drivers/net/wireless/ath9k/hw.c >> +++ b/drivers/net/wireless/ath9k/hw.c >> @@ -1008,7 +1008,7 @@ static void ath9k_hw_init_pll(struct ath_hal *ah, >> pll |= SM(0xb, AR_RTC_PLL_DIV); >> } >> } >> - REG_WRITE(ah, (u16) (AR_RTC_PLL_CONTROL), pll); >> + REG_WRITE(ah, (AR_RTC_PLL_CONTROL), pll); > > Perhaps you could remove the parentheses as well? It looks weird > otherwise. > Yes. I will do it.