From: Gabor Juhos Date: Thu, 15 Jan 2009 09:06:05 +0100 Subject: [ath9k-devel] [PATCH v4 07/11] ath9k: get EEPROM contents from platform data on AHB bus In-Reply-To: <18798.41971.397753.279649@localhost.localdomain> References: <1231960632-4452-1-git-send-email-juhosg@openwrt.org> <1231960632-4452-8-git-send-email-juhosg@openwrt.org> <18798.41971.397753.279649@localhost.localdomain> Message-ID: <496EEE6D.6090300@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Sujith ?rta: > Gabor Juhos wrote: >> +static bool ath_ahb_eeprom_read(struct ath_hal *ah, u32 off, u16 *data) >> +{ >> + struct ath_softc *sc = ah->ah_sc; >> + struct platform_device *pdev = to_platform_device(sc->dev); >> + struct ath9k_platform_data *pdata; >> + >> + pdata = (struct ath9k_platform_data *) pdev->dev.platform_data; >> + if (off >= (ARRAY_SIZE(pdata->eeprom_data))) { >> + DPRINTF(ah->ah_sc, ATH_DBG_FATAL, >> + "%s: flash read failed, offset %08x is out of range\n", >> + __func__, off); >> + return false; >> + } >> + >> + *data = pdata->eeprom_data[off]; >> + return true; >> +} >> + > > Shouldn't pdev->dev.platform_data be initalized somewhere ? It must be initialized by the board specific setup code, > @@ -48,6 +69,12 @@ static int ath_ahb_probe(struct platform_device *pdev) > int ret = 0; > struct ath_hal *ah; > > + if (!pdev->dev.platform_data) { > + dev_err(&pdev->dev, "no platform data specified\n"); > + ret = -EINVAL; > + goto err_out; > + } > + ... and we have checked it in the probe routine anyway. -Gabor