From: Jeremy Fitzhardinge Subject: Re: lmbench lat_mmap slowdown with CONFIG_PARAVIRT Date: Thu, 22 Jan 2009 16:14:04 -0800 Message-ID: <49790BCC.1040807@goop.org> References: <20090120110542.GE19505@wotan.suse.de> <20090120112634.GA20858@elte.hu> <20090120140324.GA26424@elte.hu> <49763806.5090009@goop.org> <20090120205653.GA19710@elte.hu> <20090121072718.GN24891@wotan.suse.de> <4977A051.8050203@goop.org> <1232663311.16317.176.camel@bodhitayantram.eng.vmware.com> <4978F6C6.3090003@goop.org> <1232664907.16317.182.camel@bodhitayantram.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1232664907.16317.182.camel@bodhitayantram.eng.vmware.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Zachary Amsden Cc: Nick Piggin , Xen-devel , "jeremy@xensource.com" , "rusty@rustcorp.com.au" , Linux Kernel Mailing List , "chrisw@sous-sol.org" , "hpa@zytor.com" , Ingo Molnar , Linus Torvalds , Andrew Morton List-Id: xen-devel@lists.xenproject.org Zachary Amsden wrote: > What about removing the identity functions entirely. They are useless, > really. All that is needed is a patch site filled with nops for Xen to > overwrite, just stuffing the value into the proper registers. For > 64-bit, it can be a simple mov to satisfy the constraints. > I think it comes to the same thing really. Both end up generating a series of nops with values entering and leaving in well-defined registers. The x86-64 calling convention is a bit awkward because the first arg is in rdi and the ret is rax, so it can't quite be pure nops, or we use a non-standard calling-convention with appropriate thunks to call into C code. I think a mov is a better performance-complexity tradeoff. >> Also, I just posted patches to get rid of all pvops calls when fetching >> or setting flags in a pte, which I hope will help. >> > > Sounds like it will help. > ...but apparently not. J