From: Jeremy Fitzhardinge Subject: Re: [PATCH 2/2] x86: add pte_set_flags/clear_flags forpteflag manipulation Date: Mon, 26 Jan 2009 11:54:11 -0800 Message-ID: <497E14E3.2080509@goop.org> References: <4978F216.5040803@goop.org> <49798A5E.76E4.0078.0@novell.com> <497A3117.2070809@goop.org> <497D798C.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <497D798C.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: Nick Piggin , Ingo Molnar , Xen-devel , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: > Whether a pte is live doesn't matter here: If you change P on Xen, the > frame number representation *must* change from/to PFN to/from MFN. > In no case (other than iomem pages) is it allowed to flip just this bit. Yes, true. Same with _PAGE_SPECIAL, which is actually flipped by code here. I guess a warning here might be useful, but really the calling code needs to be properly disciplined; after all setting P on a swap entry is no fun either. J