Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRY9I-00031A-El for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:33:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRY9G-0002yr-6z for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:33:34 -0500 Received: from [199.232.76.173] (port=35327 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRY9G-0002yd-0j for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:33:34 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:34824) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRY9F-0007uq-Ip for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:33:33 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n0QKVtgs016726 for ; Mon, 26 Jan 2009 13:31:55 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0QKXVxK197938 for ; Mon, 26 Jan 2009 13:33:31 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0QKXVwI031429 for ; Mon, 26 Jan 2009 13:33:31 -0700 Received: from squirrel.codemonkey.ws (sig-9-65-32-74.mts.ibm.com [9.65.32.74]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n0QKXUqG031386 for ; Mon, 26 Jan 2009 13:33:31 -0700 Message-ID: <497E1E0F.2060506@us.ibm.com> Date: Mon, 26 Jan 2009 14:33:19 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] kvm-x86: Remove eflags conversion into emulator format References: <497DFC38.6040402@siemens.com> In-Reply-To: <497DFC38.6040402@siemens.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jan Kiszka wrote: > It seems that the conversion of the kernel-delivered eflags state into > qemu's internal split representation was once needed in an older kvm > design (register read-back may have taken place from inside cpu_exec). > Today it is plain wrong and causes incorrect cpu state reporting (gdb, > monitor) and should also corrupt its saving (savevm, migration). Drop > the related lines. > > Signed-off-by: Jan Kiszka > Applied. Thanks. Regards, Anthony Liguori > --- > > target-i386/kvm.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 88c3137..47723f2 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -446,10 +446,6 @@ static int kvm_get_sregs(CPUState *env) > } > } > env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags; > - env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); > - env->df = 1 - (2 * ((env->eflags >> 10) & 1)); > - env->cc_op = CC_OP_EFLAGS; > - env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C); > > return 0; > } > > > >