From: Sean Anderson Date: Sat, 10 Oct 2020 17:47:26 -0400 Subject: [PATCH 2/2] test: log: test message continuation In-Reply-To: <20201010212840.GA31601@bill-the-cat> References: <20200917121902.57403-1-xypron.glpk@gmx.de> <20200917121902.57403-3-xypron.glpk@gmx.de> <20201010212840.GA31601@bill-the-cat> Message-ID: <497eba83-658b-19b9-e9df-317d5b788b9a@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/10/20 5:28 PM, Tom Rini wrote: > On Thu, Sep 17, 2020 at 02:19:02PM +0200, Heinrich Schuchardt wrote: > >> Provide a unit test checking that a continuation message will use the same >> log level and log category as the previous message. >> >> Signed-off-by: Heinrich Schuchardt >> Reviewed-by: Simon Glass > [snip] >> + log(LOGC_CONT, LOGL_CONT, "cc%d\n", 2); > > These new values aren't defined, or I missed some other series. Thanks! > They should be defined in the first patch On 9/17/20 8:19 AM, Heinrich Schuchardt wrote: > diff --git a/include/log.h b/include/log.h > index 2859ce1f2e..567cd32d34 100644 > --- a/include/log.h > +++ b/include/log.h > @@ -35,6 +35,7 @@ enum log_level_t { > > LOGL_FIRST = LOGL_EMERG, > LOGL_MAX = LOGL_DEBUG_IO, > + LOGL_CONT = -1, /* Use same log level as in previous call */ > }; > > /** > @@ -60,6 +61,7 @@ enum log_category_t { > > LOGC_COUNT, /* Number of log categories */ > LOGC_END, /* Sentinel value for a list of log categories */ > + LOGC_CONT = -1, /* Use same category as in previous call */ > }; > > /* Helper to cast a uclass ID to a log category */ > -- > 2.28.0 >