From: Jeremy Fitzhardinge Subject: Re: [PATCH 3 of 7] x86: fix paravirt clobber in entry_64.S Date: Thu, 29 Jan 2009 01:28:00 -0800 Message-ID: <498176A0.3020202@goop.org> References: <138b9e1650b385d5ac9d.1233182103@abulafia.goop.org> <200901291909.18929.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200901291909.18929.rusty@rustcorp.com.au> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Rusty Russell Cc: Zachary Amsden , Xen-devel , Ian Campbell , the arch/x86 maintainers , linux-kernel@vger.kernel.org, Ravikiran Thirumalai , Ingo Molnar List-Id: xen-devel@lists.xenproject.org Rusty Russell wrote: > On Thursday 29 January 2009 09:05:03 Jeremy Fitzhardinge wrote: > >> The clobber is trying to say that anything except RDI is available for >> clobbering, but actually clobbers everything. This hasn't mattered >> because the clobbers were basically ignored, but subsequent patches >> will rely on them. >> >> Signed-off-by: Jeremy Fitzhardinge >> > > Acked-by: Rusty Russell > > Hmm, did we never have the deliberate-clobbering debug code for 64 bit? > No. I think I killed it off before 64-bit was even started. There was some confusion about whether the return regs were considered to be "clobbered" or not, but I don't remember the details. J