From: Vladislav Bolkhovitin Subject: [PATCH][iSCSI-SCST]: Fix list corruption if SCST target registration fails Date: Fri, 30 Jan 2009 21:20:16 +0300 Message-ID: <498344E0.6000304@vlnb.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.188]:61289 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754830AbZA3SUI (ORCPT ); Fri, 30 Jan 2009 13:20:08 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, scst-devel@lists.sourceforge.net This patch fixes list corruption if SCST target registration fails. Signed-off-by: Arne Redlich Signed-off-by: Vladislav Bolkhovitin target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: iscsi-scst/kernel/target.c =================================================================== --- iscsi-scst/kernel/target.c (revision 648) +++ iscsi-scst/kernel/target.c (working copy) @@ -116,8 +116,6 @@ static int iscsi_target_create(struct ta mutex_init(&target->target_mutex); INIT_LIST_HEAD(&target->session_list); - list_add(&target->target_list_entry, &target_list); - target->scst_tgt = scst_register(&iscsi_template, target->name); if (!target->scst_tgt) { PRINT_ERROR("%s", "scst_register() failed"); @@ -125,6 +123,8 @@ static int iscsi_target_create(struct ta goto out_free; } + list_add(&target->target_list_entry, &target_list); + return 0; out_free: