From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: fix 32-bit build resulting from mmu move Date: Tue, 03 Feb 2009 09:14:33 -0800 Message-ID: <49887B79.4040708@goop.org> References: <49876C6E.3010809@goop.org> <20090203122112.GD19979@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090203122112.GD19979@elte.hu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ingo Molnar Cc: Linux Kernel Mailing List , the arch/x86 maintainers , Xen-devel , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org Ingo Molnar wrote: > * Jeremy Fitzhardinge wrote: > > >> Moving the mmu code from enlighten.c to mmu.c inadvertently broke the >> 32-bit build. Fix it. >> >> Signed-off-by: Jeremy Fitzhardinge >> --- >> arch/x86/xen/mmu.c | 37 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> > > that goes on top of the recent tip/x86/paravirt changes, right? No > objections, i'm wondering why my testing didnt find any build breakage. > Could you send me a .config that triggers the breakage? > Any x86-32 + Xen build would hit it. +highmem+highpte would break a bit more. J