From: Jeremy Fitzhardinge Subject: Re: [PATCH] xen: disable interrupts before saving in percpu Date: Tue, 03 Feb 2009 18:15:38 -0800 Message-ID: <4988FA4A.6080002@goop.org> References: <4988DAEA.6040608@goop.org> <4988EE04.7090006@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4988EE04.7090006@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "H. Peter Anvin" Cc: Xen-devel , Ingo Molnar , the arch/x86 maintainers , Linux Kernel Mailing List , Stable Kernel List-Id: xen-devel@lists.xenproject.org H. Peter Anvin wrote: > Jeremy Fitzhardinge wrote: > >> xen_mc_batch has a small preempt race where it takes the address of a >> percpu variable immediately before disabling interrupts, thereby >> leaving a small window in which we may migrate to another cpu and save >> the flags in the wrong percpu variable. Disable interrupts before >> saving the old flags in a percpu. >> > > Applied to tip:core/xen, thanks! Can you push this Linusward too? Thanks, J