From: "H. Peter Anvin" Subject: Re: [PATCH] xen: disable interrupts before saving in percpu Date: Tue, 03 Feb 2009 18:21:49 -0800 Message-ID: <4988FBBD.9020608@kernel.org> References: <4988DAEA.6040608@goop.org> <4988EE04.7090006@kernel.org> <4988FA4A.6080002@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4988FA4A.6080002@goop.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Ingo Molnar , the arch/x86 maintainers , Linux Kernel Mailing List , Xen-devel , Stable Kernel List-Id: xen-devel@lists.xenproject.org Jeremy Fitzhardinge wrote: > H. Peter Anvin wrote: >> Jeremy Fitzhardinge wrote: >> >>> xen_mc_batch has a small preempt race where it takes the address of a >>> percpu variable immediately before disabling interrupts, thereby >>> leaving a small window in which we may migrate to another cpu and save >>> the flags in the wrong percpu variable. Disable interrupts before >>> saving the old flags in a percpu. >>> >> >> Applied to tip:core/xen, thanks! > > Can you push this Linusward too? > Just merged into tip:core/urgent, so it should end up in the next set of pull requests. -hpa