From: Tejun Heo Subject: Re: [PATCH 2/3] xen: make direct versions of irq_enable/disable/save/restore to common code Date: Thu, 05 Feb 2009 15:31:17 +0900 Message-ID: <498A87B5.3020808@gmail.com> References: <4983AC87.5000304@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4983AC87.5000304@goop.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Ingo Molnar , Linux Kernel Mailing List , Brian Gerst , Xen-devel List-Id: xen-devel@lists.xenproject.org Hello, Jeremy Fitzhardinge wrote: > Now that x86-64 has directly accessible percpu variables, it can also > implement the direct versions of these operations, which operate on a > vcpu_info structure directly embedded in the percpu area. > > In fact, the 64-bit versions are more or less identical, and so can be > shared. The only two differences are: > 1. xen_restore_fl_direct takes its argument in eax on 32-bit, and rdi on > 64-bit. > Unfortunately it isn't possible to directly refer to the 2nd lsb of > rdi directly > (as you can with %ah), so the code isn't quite as dense. > 2. check_events needs to variants to save different registers. > > Signed-off-by: Jeremy Fitzhardinge > --- > arch/x86/xen/Makefile | 3 arch/x86/xen/xen-asm.S | 140 > +++++++++++++++++++++++++++++++++++++++++++++ > arch/x86/xen/xen-asm.h | 12 +++ > arch/x86/xen/xen-asm_32.S | 113 ++++-------------------------------- > arch/x86/xen/xen-asm_64.S | 136 > +------------------------------------------ > 5 files changed, 171 insertions(+), 233 deletions(-) ... > =================================================================== > --- a/arch/x86/xen/xen-asm_32.S > +++ b/arch/x86/xen/xen-asm_32.S > @@ -11,101 +11,28 @@ > generally too large to inline anyway. > */ > > -#include > - > -#include > +//#include Applied without the above addition of // Thanks. -- tejun