From: Jeremy Fitzhardinge Subject: Re: [PATCH] x86: style fascism for xen assemblies Date: Thu, 05 Feb 2009 09:31:22 -0800 Message-ID: <498B226A.2020900@goop.org> References: <4983AC87.5000304@goop.org> <498A87B5.3020808@gmail.com> <20090205150028.GD23903@elte.hu> <498B0E13.7060604@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <498B0E13.7060604@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tejun Heo Cc: Xen-devel , Brian Gerst , x86@kernel.org, Linux Kernel Mailing List , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner List-Id: xen-devel@lists.xenproject.org Tejun Heo wrote: > Impact: style cleanup > > Make the following sytle cleanups. > > * drop unnecessary //#include from xen-asm_32.S > Fine. > * compulsive adding of space after comma > Fine. > * reformat multiline comments > I don't really like what you've done here. There are two problems: * If you're going to convert comments of the form /* This is a small comment which happens to be longer than a line. */ then you should convert it to full winged-style, rather than just sticking '*' on the front of the second line. * All the big block comments look crowded and cramped now, which makes them harder to read and maintain. All those '*'s are just visual noise. (They make a bit more sense in C code to distinguish comment from code, but asm code looks so different from comment that they're not necessary here.) But Ingo's already pulled it, so I guess I'm stuck with it. J