From: "Jan Beulich" Subject: Re: [PATCH 8/9] tmem: invocations of tmem code fromexisting xen code Date: Fri, 06 Feb 2009 09:06:13 +0000 Message-ID: <498C0B95.76E4.0078.0@novell.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Dan Magenheimer 06.02.09 01:47 >>> >[8] invocations of tmem code from existing xen code You use do_tmem_op() directly for 32-on-64 mode, which I think is wrong given the definition of the interface structure (you'd minimally have to = use XEN_GUEST_HANDLE_64 in order for this to be correct). But even if it was right (or if you make it so), it would in my opinion be a requirement to assure it is by adding a respective entry to xen/include/xlat.lst. Jan