From: "Jan Beulich" Subject: RE: [PATCH 8/9] tmem: invocations of tmem codefromexisting xen code Date: Fri, 06 Feb 2009 14:35:27 +0000 Message-ID: <498C58BF.76E4.0078.0@novell.com> References: <498C0B95.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Dan Magenheimer 06.02.09 15:25 >>> >I have to admit I am baffled by all aspects of XEN_GUEST_HANDLE >and just hacked on it until the code worked. I would be grateful >for either an explanation of xen/include/xlat.lst or a pointer >to an explanation... or, even better, hints on how to fix >my code to properly use XEN_GUEST_HANDLE_64. The easiest thing is certainly to simply replace XEN_GUEST_HANDLE by XEN_GUEST_HANDLE_64. As to xlat.lst, just add ? entry there - the ? says the type needs to be checked, and it is followed by the type's name and the header it is found in. This will generate a CHECK_ macro in xen/include/compat/xlat.h, which you then ought to use somewhere in the source code. Just pick one of the existing entries to see how this works. Jan