From: Jeremy Fitzhardinge Subject: Re: [PATCH 5 of 7] x86/paravirt: add register-saving thunks to reduce caller register pressure Date: Fri, 06 Feb 2009 08:37:21 -0800 Message-ID: <498C6741.8000605@goop.org> References: <7d4a052c499dbfe5e816.1233182105@abulafia.goop.org> <87fxisvxb9.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87fxisvxb9.fsf@basil.nowhere.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andi Kleen Cc: Zachary Amsden , Rusty Russell , Ian Campbell , the arch/x86 maintainers , linux-kernel@vger.kernel.org, Ravikiran Thirumalai , Xen-devel , Ingo Molnar List-Id: xen-devel@lists.xenproject.org Andi Kleen wrote: > I had something like this (but not as generic) for the old pre > unification semaphores on x86-64 too. I think it's a generally useful > facility for lots of things (in fact I've been asking gcc developers > for providing this in a general way for some time). > What other users do you have in mind? > So I would suggest to move the necessary macros to do that outside > paravirt.h into a separate include so that it can be used independently > and not call it PV_*. That wouldn't be too hard to do, but I don't think its something we should do lightly. There are quite a few pitfalls, and the bugs can get pretty obscure. It would also mean bringing out a lot of the PV_CALL machinery, and I'm not sure we really want to give that too much exposure in the light of day. J