From: Jeremy Fitzhardinge Subject: Re: [PATCH 3/9] x86/paravirt: remove lazy mode in interrupts Date: Wed, 18 Feb 2009 16:17:20 -0800 Message-ID: <499CA510.2040406@goop.org> References: <06944a6dbc4ea222760d39d3d0156e50102f8196.1234988621.git.jeremy.fitzhardinge@citrix.com> <1235004837.6951.6.camel@bodhitayantram.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1235004837.6951.6.camel@bodhitayantram.eng.vmware.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Zachary Amsden Cc: Nick Piggin , Rusty Russell , Xen-devel , Peter Zijlstra , the arch/x86 maintainers , Alok Kataria , Linux Kernel Mailing List , Marcelo Tosatti , Jeremy Fitzhardinge , Thomas Gleixner , Avi Kivity , Ingo Molnar , Andrew Morton List-Id: xen-devel@lists.xenproject.org Zachary Amsden wrote: > On Wed, 2009-02-18 at 14:30 -0800, Jeremy Fitzhardinge wrote: > >> From: Jeremy Fitzhardinge >> >> Make paravirt_lazy_mode() always return PARAVIRT_LAZY_NONE >> when in an interrupt. This prevents interrupt code from >> accidentally inheriting an outer lazy state, and instead >> does everything synchronously. Outer batched operations >> are left deferred. >> > > This looks like a good solution, but can you make paravirt_lazy_mode() > inline? It doesn't need to be a function call. Yeah. I'm not quite sure why it became out of line. J