Return-path: Received: from einhorn.in-berlin.de ([192.109.42.8]:47839 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbZBSTlr (ORCPT ); Thu, 19 Feb 2009 14:41:47 -0500 Message-ID: <499DB5B7.8080802@s5r6.in-berlin.de> Date: Thu, 19 Feb 2009 20:40:39 +0100 From: Stefan Richter MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux1394-devel@lists.sourceforge.net, Christian Dolzer , Andreas Monitzer , Manu Abraham , Fabio De Lorenzo , Robert Berger , Ben Backx , Henrik Kurelid , Rambaldi Subject: Re: [review patch 0/1] add firedtv driver for FireWire-attached DVB receivers References: <20090217102951.21dab08c@pedra.chehab.org> In-Reply-To: <20090217102951.21dab08c@pedra.chehab.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Mauro Carvalho Chehab wrote: > The driver looks sane to my eyes. I found just one minor issue (see bellow). > Acked-by: Mauro Carvalho Chehab Thanks for checking. >> + >> + /* >> + * AV/C specs say that answers should be sent within 150 ms. >> + * Time out after 200 ms. >> + */ >> + if (wait_event_timeout(fdtv->avc_wait, >> + fdtv->avc_reply_received, >> + HZ / 5) != 0) { > > Instead of using HZ, it would be better to use: > msecs_to_jiffies(200) OK, I switch this. (Hmm, what if msecs_to_jiffies could be rolled out to a constant expression if called on a constant argument...?) -- Stefan Richter -=====-==--= --=- =--== http://arcgraph.de/sr/