Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1PJR9Wx006243 for ; Wed, 25 Feb 2009 14:27:09 -0500 Received: from smtp103.biz.mail.re2.yahoo.com (smtp103.biz.mail.re2.yahoo.com [68.142.229.217]) by mx3.redhat.com (8.13.8/8.13.8) with SMTP id n1PJQl9C017320 for ; Wed, 25 Feb 2009 14:26:47 -0500 Message-ID: <49A59B31.9080407@embeddedalley.com> Date: Wed, 25 Feb 2009 22:25:37 +0300 From: Vitaly Wool MIME-Version: 1.0 To: Mauro Carvalho Chehab References: <49A3A61F.30509@embeddedalley.com> <20090224234205.7a5ca4ca@pedra.chehab.org> <49A53CB9.1040109@embeddedalley.com> <20090225090728.7f2b0673@caramujo.chehab.org> <49A567D9.80805@embeddedalley.com> <20090225101812.212fabbe@caramujo.chehab.org> <49A57BD4.6040209@embeddedalley.com> <20090225153323.66778ad2@caramujo.chehab.org> In-Reply-To: <20090225153323.66778ad2@caramujo.chehab.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: video4linux-list@redhat.com, em28xx@mcentral.de Subject: Re: em28xx: Compro VideoMate For You sound problems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: video4linux-list-bounces@redhat.com Errors-To: video4linux-list-bounces@redhat.com List-ID: Mauro, Mauro Carvalho Chehab wrote: > >> diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c >> index 100f90a..f300e74 100644 >> --- a/drivers/media/video/em28xx/em28xx-cards.c >> +++ b/drivers/media/video/em28xx/em28xx-cards.c >> @@ -1245,14 +1245,17 @@ struct em28xx_board em28xx_boards[] = { >> .tda9887_conf = TDA9887_PRESENT, >> .decoder = EM28XX_TVP5150, >> .adecoder = EM28XX_TVAUDIO, >> + .tuner_gpio = default_tuner_gpio, >> > > You don't need a tuner gpio. This is used basically by xc3028 based devices, in > order to reset it during software upload. > > Instead, we should add another gpio here, for mute. This should be called in a > place where we can remove the unwanted noise (e. g. at the beginning of the > device setup logic), and when mute is selected by the audio functions. > I'm not quite sure I understood. Do I need to add another field to the board structure and use it where appropriate? Thanks, Vitaly -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list