Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ldt2J-0000G9-IU for mharc-grub-devel@gnu.org; Sun, 01 Mar 2009 16:17:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ldt2G-0000CX-UY for grub-devel@gnu.org; Sun, 01 Mar 2009 16:17:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ldt2G-0000BK-6q for grub-devel@gnu.org; Sun, 01 Mar 2009 16:17:20 -0500 Received: from [199.232.76.173] (port=40409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ldt2G-0000B6-39 for grub-devel@gnu.org; Sun, 01 Mar 2009 16:17:20 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:60276) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ldt2F-00057T-Lo for grub-devel@gnu.org; Sun, 01 Mar 2009 16:17:19 -0500 Received: by fg-out-1718.google.com with SMTP id l27so849200fgb.30 for ; Sun, 01 Mar 2009 13:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=aUPA/NzR9CQOzpJEyXOWI6/oJr56SXYXWbyw1MxcAaA=; b=rsAZwH53F5xdr8/hUlPhNOB9/++P3XS6xsgqvfjcJfesZv87YlMLwSw1ksLilykGkV N74bbfB3Z5c8wlSjV4mZfeD3l4ByKtjzfaYj3qCvf6jlB5vix3Unww4l6/S0MVqoiWIW N7oX3aWlE7Z/TnOTLCB3ERZKW0OoRr4t259Gg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=NUBe1PsVscNfA+NbBluFQqH8k5Y3Hr1UZdhWS5t0MYZyDtBH3+Bb+FK1BZ4ad3CQVM 6Wfo15lz3d2lpu8TF9ylSEkxhSK11lm3Q+i9381fQNTW/L1e7OiUskWCmpN8G6YXmd8B eE8oIQapPklQ7sOSQoXQppNkUePwxNWJalnGg= Received: by 10.86.91.3 with SMTP id o3mr143233fgb.17.1235942238399; Sun, 01 Mar 2009 13:17:18 -0800 (PST) Received: from ?192.168.1.2? (211-140.79-83.cust.bluewin.ch [83.79.140.211]) by mx.google.com with ESMTPS id 4sm6905391fge.44.2009.03.01.13.17.17 (version=SSLv3 cipher=RC4-MD5); Sun, 01 Mar 2009 13:17:18 -0800 (PST) Message-ID: <49AAFB5D.8060007@gmail.com> Date: Sun, 01 Mar 2009 22:17:17 +0100 From: phcoder User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: The development of GRUB 2 References: <49AAB6E6.2080805@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] FAT, UFS and mtime X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2009 21:17:21 -0000 Bean wrote: > On Mon, Mar 2, 2009 at 12:25 AM, phcoder wrote: >> Hello all. It seems that gcc has trouble with -m32 when structure is passed >> as argument. So I replaced that part by a pointer. Also I made some >> improvements to ufs code to support solaris branch of ufs. I tested it also >> with freebsd and netbsd's branch and it works fine on it too. >> As my 3 FS patches: mtime, FAT and UFS are interdependent I submit a patch >> with all 3 features. If it's really necessary I can split them but it >> requires a lot of unnecessary work > > Hi, > > Please don't merge patch, it makes it harder to track down bugs later. > Actually these patches aren't merged. The problem is that my copyright assignment hasn't been signed by FSF yet so uncommited patches accumulate in my grub2 tree > > Also, perhaps you should keep datetime.c as it is. I'm planning to > split the normal mode into separate components, it'd be nice if you > don't add files to the normal directory. > Feel free to put datetime.c wherever you want -- Regards Vladimir 'phcoder' Serbinenko