Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lephw-0002d5-2R for mharc-grub-devel@gnu.org; Wed, 04 Mar 2009 06:56:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lephu-0002bU-4g for grub-devel@gnu.org; Wed, 04 Mar 2009 06:56:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lephs-0002Ze-HF for grub-devel@gnu.org; Wed, 04 Mar 2009 06:56:13 -0500 Received: from [199.232.76.173] (port=58979 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lephs-0002ZY-E5 for grub-devel@gnu.org; Wed, 04 Mar 2009 06:56:12 -0500 Received: from mta-out.inet.fi ([195.156.147.13]:36549 helo=jenni1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lephr-0005mh-Ih for grub-devel@gnu.org; Wed, 04 Mar 2009 06:56:12 -0500 Received: from [192.168.1.102] (84.248.105.254) by jenni1.inet.fi (8.5.014) id 49ACEA30000F93E6 for grub-devel@gnu.org; Wed, 4 Mar 2009 13:56:10 +0200 Message-ID: <49AE6C58.1030709@nic.fi> Date: Wed, 04 Mar 2009 13:56:08 +0200 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: The development of GRUB 2 References: <20090304.004254.206977696.davem@davemloft.net> In-Reply-To: <20090304.004254.206977696.davem@davemloft.net> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH]: Fix several warnings on sparc64. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2009 11:56:14 -0000 David Miller wrote: > Many of these warnings are for two reasons: > > 1) grub_ssize_t is != 'int' on sparc64, and many pieces of code > try to pass an int pointer in for the final arg of several > ieee1275 "get property" functions which take a grub_ssize_t > pointer. > > 2) The third arg to grub_ieee1275_get_integer_property is > "uint32_t *" but we try passing pointers to grub_ieee1275_ihandle_t > objects there, but those are of grub_ieee1275_cell_t type, > which is uint64_t on sparc64. > > diff --git a/kern/ieee1275/cmain.c b/kern/ieee1275/cmain.c > index b5e2ba6..847d9fd 100644 > --- a/kern/ieee1275/cmain.c > +++ b/kern/ieee1275/cmain.c > @@ -157,11 +157,15 @@ grub_ieee1275_find_options (void) > void > grub_ieee1275_init (void) > { > + uint32_t val; Please use grub_uint32_t instead... (I know..) This same applies to other instances of that same type too... > diff --git a/term/ieee1275/ofconsole.c b/term/ieee1275/ofconsole.c > index 70fda9a..c24a4c2 100644 > --- a/term/ieee1275/ofconsole.c > +++ b/term/ieee1275/ofconsole.c > @@ -341,12 +341,15 @@ static grub_err_t > grub_ofconsole_init_input (void) > { > grub_ssize_t actual; > + uint32_t val; > > - if (grub_ieee1275_get_integer_property (grub_ieee1275_chosen, "stdin", &stdin_ihandle, > + if (grub_ieee1275_get_integer_property (grub_ieee1275_chosen, "stdin", &val, > sizeof stdin_ihandle, &actual) > || actual != sizeof stdin_ihandle) > return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "Cannot find stdin"); > > + stdin_ihandle = val; Why stdin_ihandle is not in proper type ? Or was there some other reason for this change?