From: "Jan Beulich" Subject: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allowguests to use it Date: Mon, 09 Mar 2009 11:26:33 +0000 Message-ID: <49B50AF9.76E4.0078.0@novell.com> References: <49B35829.1010403@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <49B35829.1010403@goop.org> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Jeremy Fitzhardinge Cc: Boris Derzhavets , Xen-devel , "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" List-Id: xen-devel@lists.xenproject.org >>> Jeremy Fitzhardinge 08.03.09 06:31 >>> >Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests to >use it (by setting cr4.OSXSAVE). I actually disagree to this. The kernel should be dealing with the = situation by inspecting the OSXSAVE bit in CPUID when running under Xen, since it's really Xen that's the 'OS' for that particular feature. Then, once Keir gets willing to take Intel xsave patch(es), no further = change is going to be needed here. And the same kernel will work (assuming it has no other dependencies) on older Xen not having this bit masked. Jan