From: "Jan Beulich" Subject: Re: [PATCH] xen: mask XSAVE in cpuid since we don'tallow guests to use it Date: Mon, 09 Mar 2009 11:31:02 +0000 Message-ID: <49B50C06.76E4.0078.0@novell.com> References: <49B35829.1010403@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser , Jeremy Fitzhardinge Cc: Boris Derzhavets , Xen-devel , "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 08.03.09 10:13 >>> >On 08/03/2009 05:31, "Jeremy Fitzhardinge" wrote: > >> Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests = to >> use it (by setting cr4.OSXSAVE). >>=20 >> This prevents crashes in pvops dom0 kernels, as new versions of Linux = try >> to use this feature. >>=20 >> (This patch deals with dom0 cpuid; I'm not sure where the right place = to >> set up the default mask for domU is.) > >Thanks, the whole problem stems from blacklisting rather than whitelisting= >feature bits. I might try and do a more comprehensive job for xen-unstable= >at least. This is good for 3.3. I'm not sure whitelisting will be much better than blacklisting - while = now any feature requiring not-yet-implemented support in Xen must be turned off explicitly, this would just turn over to requiring explicitly = un-hiding any new feature not requiring Xen's intervention. A real solution to this = issue would require some assistance from the hardware vendors I'd think. Jan