From: "Jan Beulich" Subject: [PATCH] linux/PCI-MSI: fix compiler warnings resulting from c/s 790 Date: Thu, 19 Mar 2009 08:24:59 +0000 Message-ID: <49C20F6B.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: qing.he@intel.com List-Id: xen-devel@lists.xenproject.org The one in pci_enable_msix() is rather meaningful, as the uninitialized inner msi_dev_entry was indeed hiding the initialized outer one. As usual, written and tested on 2.6.29-rc8 and made apply to the 2.6.18 tree without further testing. Signed-off-by: Jan Beulich --- head-2009-03-18.orig/drivers/pci/msi-xen.c 2009-03-18 16:08:41.0000000= 00 +0100 +++ head-2009-03-18/drivers/pci/msi-xen.c 2009-03-18 17:30:44.0000000= 00 +0100 @@ -612,7 +612,6 @@ int pci_enable_msix(struct pci_dev* dev, =20 #ifdef CONFIG_XEN_PCIDEV_FRONTEND if (!is_initial_xendomain()) { - struct msi_dev_list *msi_dev_entry; struct msi_pirq_entry *pirq_entry; int ret, irq; =20 @@ -625,7 +624,6 @@ int pci_enable_msix(struct pci_dev* dev, } msi_dev_entry->default_irq =3D temp; =20 - msi_dev_entry =3D get_msi_dev_pirq_list(dev); for (i =3D 0; i < nvec; i++) { int mapped =3D 0; =20 @@ -688,8 +686,6 @@ void pci_disable_msix(struct pci_dev* dev { int pos; u16 control; - struct msi_dev_list *msi_dev_entry =3D get_msi_dev_pirq_list(dev); - =20 if (!pci_msi_enable) return;