From: Eric Dumazet Subject: Re: Regression caused by commit "netfilter: iptables: lock free counters" Date: Sun, 05 Apr 2009 12:01:06 +0200 Message-ID: <49D88162.5040809@cosmosbay.com> References: <20090329234702.4988017f@desktop.r000n.info> <8763hja8cy.fsf@newton.gmurray.org.uk> <20090405.012237.198610462.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: graham@gmurray.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: David Miller Return-path: In-Reply-To: <20090405.012237.198610462.davem@davemloft.net> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller a =E9crit : > From: Graham Murray > Date: Sun, 05 Apr 2009 08:05:17 +0100 >=20 > Please CC the appropriate mailing lists (as I have now) when reportin= g > this incredibly useful information. The networking and netfilter > developers largely do not read linux-kernel. >=20 >> Roman Mindalev writes: >> >>> Result of the bisection: >>> >>> 784544739a25c30637397ace5489eeb6e15d7d49 is first bad commit >>> commit 784544739a25c30637397ace5489eeb6e15d7d49 =20 >> I am seeing a different problem which also bisects to this commit. T= here are >> no kernel messages but ip6tables fails to run. >> >> newton ~ # ip6tables -L -v >> FATAL: Module ip6_tables not found. >> ip6tables v1.4.3.1: can't initialize ip6tables table `filter': Memor= y allocation problem >> Perhaps ip6tables or your kernel needs to be upgraded. >> >> I get this error no matter which ip6tables sub-command I run. Ip6tab= les >> is built into the kernel, not as modules. >> >> An strace shows the failure to be=20 >> socket(PF_INET6, SOCK_RAW, IPPROTO_RAW) =3D 3 >> getsockopt(3, SOL_IPV6, 0x40 /* IPV6_??? */, "filter\0\305\0w~\300\0= wb\305P\24\312\t\0009b\305\216\23\0\0\310\341/g\16"..., [84]) =3D 0 >> brk(0) =3D 0x8273000 >> brk(0x8294000) =3D 0x8294000 so ip6tables allocates about 128 Kbytes of ram in order to get rules fr= om kernel. >> getsockopt(3, SOL_IPV6, 0x41 /* IPV6_??? */, 0x8273090, 0xbfd23628) = =3D -1 ENOMEM (Cannot allocate memory) >> close(3) =3D 0 >> This is a big problem yes, since "iptables|ip6tables" -L needs to alloc= ate kernel memory to perform the momentary swap. On x86, this is potentially a problem if vmalloc space is exhausted or = fragmented, (or lowmem exhausted) and/or many cpus are online/possible. Graham, could you please give us : # cat /proc/vmallocinfo # cat /proc/meminfo I wonder if your machine is in a state where even an "ip6tables -A ..."= would fail anyway since it should allocate same amount of memory than "ip6tables -L " This could probably be solved using a single "table" containing rules o= nly, that could be shared for every cpus. Only counters should be percpu. This should s= ave a lot of ram, over previous situation (2.6.29 or current one) (current scheme is to allocate a copy of all rules logic *and* counters= per cpu) Then if we want to be sure "iptables -L" cannot fail, we should reserve= this extra space at load time (iptables -{A|I}", instead. Other possibility is to use a percpu seqlock as Stephen did in one of h= is patch, and not swap tables when doing "iptables -L". This would slowdown fast path a litle bit (one spinlock/spinunlock) per= ipt_do_table() call.=20 -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html