From: Jeremy Fitzhardinge Subject: Re: [PATCH 2/5] xen/x86-64: clean up warnings aboutIST-using traps Date: Fri, 08 May 2009 08:23:01 -0700 Message-ID: <4A044E55.20803@goop.org> References: <4A032EE0.9030607@goop.org> <4A03F947.76EA.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A03F947.76EA.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: Ingo Molnar , the arch/x86 maintainers , Linus Torvalds , Xen-devel , Linux Kernel Mailing List List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: >> else if (addr == (unsigned long)int3) >> addr = (unsigned long)xen_int3; >> - else >> - WARN_ON(val->ist != 0); >> + else if (addr == (unsigned long)double_fault || >> + addr == (unsigned long)stack_segment) { >> > > I don't think you want to exclude handling stack faults: Ordinary memory > references using rsp or rbp as the base register will cause these instead > of general protection faults when the resulting effective address is non- > canonical. > So even usermode memory accesses? Ew. Well, we can run the trap handler on the normal kernel stack in that case. I'll cook something up. J