From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] Performance overhead of paravirt_ops on nativeidentified Date: Fri, 15 May 2009 11:50:48 -0700 Message-ID: <4A0DB988.6000009@goop.org> References: <4A0B62F7.5030802@goop.org> <4A0BED040200007800000DB0@vpn.id2.novell.com> <4A0C58BB.3090303@goop.org> <4A0D3F8C02000078000010A7@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A0D3F8C02000078000010A7@vpn.id2.novell.com> Sender: linux-kernel-owner@vger.kernel.org To: Jan Beulich Cc: Ingo Molnar , Jun Nakajima , Xiaohui Xin , Xin Li , Xen-devel , Nick Piggin , Linux Kernel Mailing List , "H. Peter Anvin" List-Id: xen-devel@lists.xenproject.org Jan Beulich wrote: > A patch for the pv-ops kernel would require some time. What I can give you > right away - just for reference - are the sources we currently use in our kernel: > attached. Hm, I see. Putting a call out to a pv-ops function in the ticket lock slow path looks pretty straightforward. The need for an extra lock on the contended unlock side is a bit unfortunate; have you measured to see what hit that has? Seems to me like you could avoid the problem by using per-cpu storage rather than stack storage (though you'd need to copy the per-cpu data to stack when handling a nested spinlock). What's the thinking behind the xen_spin_adjust() stuff? > static __always_inline void __ticket_spin_lock(raw_spinlock_t *lock) { > unsigned int token, count; bool free; __ticket_spin_lock_preamble; if > (unlikely(!free)) token = xen_spin_adjust(lock, token); do { count = 1 > << 10; __ticket_spin_lock_body; } while (unlikely(!count) && > !xen_spin_wait(lock, token)); } How does this work? Doesn't it always go into the slowpath loop even if the preamble got the lock with no contention? J