From: Jeremy Fitzhardinge Subject: Re: Performance overhead of paravirt_ops on native identified Date: Thu, 21 May 2009 15:48:46 -0700 Message-ID: <4A15DA4E.2090505@goop.org> References: <4A0B62F7.5030802@goop.org> <20090521184233.3c3e97ad@dhcp-100-2-144.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090521184233.3c3e97ad@dhcp-100-2-144.bos.redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chuck Ebbert Cc: Nick Piggin , "Xin, Xiaohui" , Xen-devel , Linux Kernel Mailing List , "Li, Xin" , "Nakajima, Jun" , "H. Peter Anvin" , Ingo Molnar List-Id: xen-devel@lists.xenproject.org Chuck Ebbert wrote: > On Wed, 13 May 2009 17:16:55 -0700 > Jeremy Fitzhardinge wrote: > > >> Paravirt patching turns all the pvops calls into direct calls, so >> _spin_lock etc do end up having direct calls. For example, the compiler >> generated code for paravirtualized _spin_lock is: >> >> <_spin_lock+0>: mov %gs:0xb4c8,%rax >> <_spin_lock+9>: incl 0xffffffffffffe044(%rax) >> <_spin_lock+15>: callq *0xffffffff805a5b30 >> <_spin_lock+22>: retq >> >> The indirect call will get patched to: >> <_spin_lock+0>: mov %gs:0xb4c8,%rax >> <_spin_lock+9>: incl 0xffffffffffffe044(%rax) >> <_spin_lock+15>: callq <__ticket_spin_lock> >> <_spin_lock+20>: nop; nop /* or whatever 2-byte nop */ >> <_spin_lock+22>: retq >> >> > > Can't those calls be changed to jumps? > In this specific instance of this example, yes. But if you start enabling various spinlock debug options then there'll be code following the call. It would be hard for the runtime patching machinery to know when it would be safe to do the substitution. J