From: "H. Peter Anvin" Subject: Re: Performance overhead of paravirt_ops on native identified Date: Thu, 21 May 2009 16:10:06 -0700 Message-ID: <4A15DF4E.6060209@zytor.com> References: <4A0B62F7.5030802@goop.org> <20090521184233.3c3e97ad@dhcp-100-2-144.bos.redhat.com> <4A15DA4E.2090505@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A15DA4E.2090505@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Nick Piggin , "Xin, Xiaohui" , Xen-devel , Chuck Ebbert , Linux Kernel Mailing List , "Li, Xin" , "Nakajima, Jun" , Ingo Molnar List-Id: xen-devel@lists.xenproject.org Jeremy Fitzhardinge wrote: > > In this specific instance of this example, yes. But if you start > enabling various spinlock debug options then there'll be code following > the call. It would be hard for the runtime patching machinery to know > when it would be safe to do the substitution. > "When it is immediately followed by a ret" seems like a straightforward rule to me? -hpa