From: "H. Peter Anvin" Subject: Re: Performance overhead of paravirt_ops on native identified Date: Thu, 21 May 2009 20:39:01 -0700 Message-ID: <4A161E55.4040401@zytor.com> References: <4A0B62F7.5030802@goop.org> <20090521184233.3c3e97ad@dhcp-100-2-144.bos.redhat.com> <4A15DA4E.2090505@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Xin, Xiaohui" Cc: Nick Piggin , Jeremy Fitzhardinge , Xen-devel , Chuck Ebbert , Linux Kernel Mailing List , "Li, Xin" , "Nakajima, Jun" , Ingo Molnar List-Id: xen-devel@lists.xenproject.org Xin, Xiaohui wrote: > Remember we have done one experiment with "jump", the result shows seems the overhead is even more than the call. I didn't, no. That seems extremely weird to me. (Unbalancing the call/ret stack is known to suck royally, of course.) >>> >>> >> Can't those calls be changed to jumps? >> > > In this specific instance of this example, yes. But if you start > enabling various spinlock debug options then there'll be code following > the call. It would be hard for the runtime patching machinery to know > when it would be safe to do the substitution. > When there is code after the call, it's rather obviously not safe. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.