From: Jeremy Fitzhardinge Subject: Re: [PATCH RFC] x86/acpi: don't ignore I/O APICs just because there's no local APIC Date: Sun, 14 Jun 2009 19:01:16 -0700 Message-ID: <4A35AB6C.7090605@goop.org> References: <4A329CF8.4050502@goop.org> <20090612201117.GA29923@lenovo> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090612201117.GA29923@lenovo> Sender: linux-kernel-owner@vger.kernel.org To: Cyrill Gorcunov Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , "Eric W. Biederman" , the arch/x86 maintainers , Linux Kernel Mailing List , Xen-devel List-Id: xen-devel@lists.xenproject.org On 06/12/09 13:11, Cyrill Gorcunov wrote: > just for the record -- this removement has a side effect. > Imagine I've passed "disableapic" so I expect as many as > possible apic-related code would not pass thru execution. > Now we would have (say for IBM Summit) > > acpi_parse_madt > default_acpi_madt_oem_check > summit_acpi_madt_oem_check > mark_tsc_unstable > setup_summit > > Dunno if it harmless or no but it changes kernel behaviour. > cpu_has_apic cleared if disableapic option (which is early > param) passed to kernel. > > Just a note. Didn't walk thru all ways. > Yeah, that occured to me over the weekend. Some of those cpu_has_apic tests should probably be replaced with explicit tests to see if noapic was specified. I'll go over it with that in mind. Thanks, J