From: Boaz Harrosh Subject: Re: [PATCH block#for-2.6.31] block: add request clone interface (v2) Date: Mon, 15 Jun 2009 12:30:57 +0300 Message-ID: <4A3614D1.20403@panasas.com> References: <4A3075B2.9040208@ct.jp.nec.com> <20090611110903.GO11363@kernel.dk> <20090612133014.GK11363@kernel.dk> <4A35C0A4.20707@ct.jp.nec.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A35C0A4.20707@ct.jp.nec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Kiyoshi Ueda Cc: Jun'ichi Nomura , Jeff Moyer , linux-kernel@vger.kernel.org, device-mapper development , Jens Axboe List-Id: dm-devel.ids On 06/15/2009 06:31 AM, Kiyoshi Ueda wrote: > Hi Jeff, > > On 06/12/2009 11:33 PM +0900, Jeff Moyer wrote: >> Jens Axboe writes: >>> On Thu, Jun 11 2009, Jeff Moyer wrote: >>>> Jens Axboe writes: >>>> Is blk_rq_unprep_clone really the best name? >>>> ^^^^^^ >>> Probably not, but I'm not very good at coming up with elegant names. >>> Your email should have included a new suggestion :-) >> Fair enough. ;) >> >>> - blk_rq_unprep_clone(struct request *clone) >>> * Frees cloned bios from the clone request. >> Why not blk_rq_free_clone? > > Because the 'clone' is not freed in this interface. > This interface frees only bios in the 'clone'. > Allocating/freeing the 'clone' are the caller's work, since > only the caller knows how to allocate/free it. > > 'prep' after 'alloc' and 'unprep' before 'free' is symmetric > and I feel a good candidate for my request-stacking driver, > so I chose it. > > Thanks, > Kiyoshi Ueda I'm not a native English speaker as well, so I'm fine with blk_rq_{prep,unprep}_clone. But maybe the English people don't like it? Perhaps blk_rq_{clone,declone} or blk_rq_{clone,declone}_bios (Both unclone and declone are found on the net but are not found in the free dictionary) Boaz